1. Obviously this is a very thin spot - there arent many favorable flop textures for you. I see that you have a reason to complete VS fish, but for me I would just let it go.

2. When you XR flop, you really start to isolate yourself to the value side of the Rec players' range when they continue. I see that you have a good spot to pick up some dead money, but once he calls, what plan do you have OTT? If called and any non-diamond broadway rolls off, you are in a tough spot with a 1:1 SPR as his range looks like Jx/AT/QK a lot here and I dont think you have much FE there otherwise if a non-diamond comes. Also, your two-pair out to the 8 may be straightening outs for villain (if not already dead vs higher 2p)
   Once UTG calls and button moves in, It really put the Buttons range faceup to Sets/toptwo that wants to Get it in before a scary card comes, or Monster draws (AQdd/KQdd) that weren't raising the flop to get more $ip. JTx flops are very hard to get people off as they aren't stacking off with overpairs and also arent afraid to get it in with OES+2overs & flushdraws.

3. If my math is right, there is Pot+xr+1 call+shove so 50+250+250+990=1540. and its 740 more to you. 1540:740 = ~2:1, and if the other Villain calls too, implied odds of closer to 3-1. Although we only need ~35% equity to call here, I believe we are often getting it in with Reverse ImpOdds vs another flush draw a very large amount of time. I think that a fold is fine here, we don't need to go broke in a limped pot with the bottom part of our XR range here.

If you wanna take an aggro line, i think the best is just leading the flop and trying to make folding people better hand than 2x or better FD than you.

I don't mind your x/r, it's often good, or slightly minus EV, but if you don't take the lead flop, you prob don't take it on the turn, and if you don't improve you loose vs Q2hh lol, that's why i think leading is clear better than xring, and i don't think ppl are taking the stab so wide in 5 ways pot, that we can expect a lot of fold equity.
But your hand is nice to do it, you have a bunch of equity, and you block the nuttest hand 22, (JJ TT would raise , maybe not in live game sometimes) .

I think your line is okay, just don't be result oriented because the guy show up with nuts or whatever, you have paire+FD nothing can't be bad, it's not spewy, but you can make better for sure.

XR is def mistake agaist the rec players. You dont have any FE and they are not capped. I can see no reason to do that.
Leeding is the best play here imo, I would leed all my 2 pairs and probably I dont have a XR range on that type of board in this particular situation. You can even exploitly overbet when you want, fish doesnt care)